Skip to content

lib: validate sequence iterator objects - #65844

Open
panva wants to merge 1 commit into
nodejs:mainfrom
panva:webidl-sequence-iterator-validation
Open

lib: validate sequence iterator objects#65844
panva wants to merge 1 commit into
nodejs:mainfrom
panva:webidl-sequence-iterator-validation

Conversation

@panva

@panva panva commented Sep 6, 2026

Copy link
Copy Markdown
Member

Reject primitive iterator factory results before accessing next, as required by GetIteratorFromMethod.

Reject primitive iterator factory results before accessing next, as
required by GetIteratorFromMethod.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 6, 2026
@panva panva added the web-standards Issues and PRs related to web-platform APIs and standards compliance. label Sep 6, 2026
@panva

panva commented Sep 6, 2026

Copy link
Copy Markdown
Member Author

cc @nodejs/web-standards

@jazelly jazelly left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov

codecov Bot commented Sep 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.18%. Comparing base (6f41e41) to head (7fac560).
⚠️ Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65844      +/-   ##
==========================================
+ Coverage   90.17%   90.18%   +0.01%     
==========================================
  Files         770      771       +1     
  Lines      264483   264627     +144     
  Branches    50262    50233      -29     
==========================================
+ Hits       238491   238650     +159     
+ Misses      16981    16964      -17     
- Partials     9011     9013       +2     
Files with missing lines Coverage Δ
lib/internal/webidl.js 100.00% <100.00%> (ø)

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 6, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@gurgunday gurgunday left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. web-standards Issues and PRs related to web-platform APIs and standards compliance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants