stream: amortize writable buffer compaction - #65847
Open
gurgunday wants to merge 1 commit into
Open
Conversation
Signed-off-by: Gürgün Dayıoğlu <hey@gurgun.day> Assisted-by: Codex
Collaborator
|
Review requested:
|
ronag
approved these changes
Sep 6, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65847 +/- ##
========================================
Coverage 90.18% 90.18%
========================================
Files 770 771 +1
Lines 264410 264622 +212
Branches 50230 50232 +2
========================================
+ Hits 238449 238653 +204
+ Misses 16966 16956 -10
- Partials 8995 9013 +18
🚀 New features to boost your workflow:
|
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Writablecompacts its pending-write array after consuming more than 256 entries, even when most of the queue remains. Therefore draining a large backlog repeatedly shifts the remaining entriesSolution
Compact only once at least half the array has been consumed, keeping queue compaction amortized linear. Consumed entries are still cleared immediately