typings: wire up spawn_sync internal binding types - #65996
Merged
nodejs-github-bot merged 2 commits intoSep 27, 2026
Merged
Conversation
Signed-off-by: agape1225 <49804691+agape1225@users.noreply.github.com>
nodejs-github-bot
added
the
typings
daeyeon
reviewed
Sep 21, 2026
daeyeon
left a comment
daeyeon
left a comment
Member
There was a problem hiding this comment.
Some types don't seem to fully match the implementation. For example, uid also accepts null, and stdio[].input accepts any ArrayBufferView.
Address review feedback from daeyeon: several fields accept more than what was typed. - src/spawn_sync.cc checks uid, gid, timeout, maxBuffer, and killSignal with IsNullOrUndefined(), same as cwd/envPairs, so null is a valid "unset" value for all of them, not just undefined. - stdio[].input is passed to Buffer::HasInstance(), whose actual definition (src/node_buffer.cc) is just val->IsArrayBufferView() - any ArrayBufferView is accepted, not only Uint8Array. Signed-off-by: agape1225 <49804691+agape1225@users.noreply.github.com>
daeyeon
approved these changes
Sep 25, 2026
daeyeon
added
author ready
Collaborator
|
Landed in cf0434f |
nodejs-github-bot
removed
the
commit-queue
aduh95
pushed a commit
that referenced
this pull request
Sep 27, 2026
Signed-off-by: agape1225 <49804691+agape1225@users.noreply.github.com> PR-URL: #65996 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
HoonDongKang
pushed a commit
to HoonDongKang/node
that referenced
this pull request
Sep 28, 2026
Signed-off-by: agape1225 <49804691+agape1225@users.noreply.github.com> PR-URL: nodejs#65996 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Sep 28, 2026
Signed-off-by: agape1225 <49804691+agape1225@users.noreply.github.com> PR-URL: #65996 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add typings for the spawn_sync internal binding.