test: deflake test-run-watch-cwd-isolation-none-* - #66035
Merged
Merged
Conversation
nodejs-github-bot
added
needs-ci
aduh95
force-pushed
the
test-watch-flakes
branch
from
September 15, 2026 13:45
68dce3d to
cd6f523
Compare
aduh95
changed the title
test-run-watch-cwd-isolation-none-*
panva
added
the
flaky-test
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66035 +/- ##
==========================================
+ Coverage 90.27% 90.28% +0.01%
==========================================
Files 790 790
Lines 271642 271642
Branches 51840 51843 +3
==========================================
+ Hits 245214 245252 +38
+ Misses 16939 16887 -52
- Partials 9489 9503 +14 🚀 New features to boost your workflow:
|
Member
|
Drop the |
panva
approved these changes
Sep 15, 2026
lpinca
approved these changes
Sep 15, 2026
aduh95
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
Contributor
Author
Humpf failure on Windows |
Contributor
Author
|
I don't have a win-arm64 machine, and I wasn't able to reproduce to x86: > python.exe .\tools\test.py --shell=../v27.0.0-nightly2026090729667e046b/win-x64/node.exe --repeat 9999 test/test-runner/test-run-watch-cwd-isolation-none.mjs test/test-runner/test-run-watch-cwd-isolation-none-argv.mjs
[17:27|% 100|+ 19998|- 0]: DoneI guess I'll mark it as flaky on that platform and move on |
aduh95
added
request-ci
Collaborator
aduh95
added
the
author ready
github-actions
Bot
removed
the
author ready
Contributor
|
This pull request has conflicts with its base branch, removing the |
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
force-pushed
the
test-watch-flakes
branch
from
September 18, 2026 13:25
b2e7b65 to
c5f7178
Compare
Collaborator
Contributor
Author
|
Landed in ebef774 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 30, 2026
Windows directory watchers report last-access time updates. Reading cold fixtures in the child can therefore trigger test:watch:restarted before it exits, failing the mustNotCall assertion without printing the error. Read the fixtures before starting watch mode and remove the Windows flaky expectation. With old access times and a delayed child exit, the original fails 10/10 runs and the change passes 100/100 on Windows. Also remove the argv variant's stale flaky expectation. It passes repeated local Windows runs and the inspected CI history after #66035. Refs: #66056 Refs: #66035 Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex PR-URL: #66320 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, on my machine:
With this PR:
Refs: #66056