Skip to content

worker: remove messageerror listeners on exit - #66075

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
dayun6530:fix/worker-messageerror-listener-cleanup
Sep 26, 2026
Merged

nodejs-github-bot merged 1 commit into
nodejs:mainfrom
dayun6530:fix/worker-messageerror-listener-cleanup

Conversation

@dayun6530

Copy link
Copy Markdown
Contributor

Fixes a typo in the worker exit cleanup so messageerror listeners are removed before the exit event is emitted.

Adds a regression test covering the listener cleanup behavior.

Tests:

  • python3 tools/test.py --mode=release parallel/test-worker-messageerror-listener-cleanup
  • make lint-js

Fixes: #65782

Signed-off-by: Dayun <dlekdbs6530@gmail.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. worker Issues and PRs related to the worker_threads module and Worker API. labels Sep 17, 2026
@dayun6530
dayun6530 marked this pull request as ready for review September 17, 2026 01:54
@codecov

codecov Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.24%. Comparing base (c081d10) to head (734c24d).
⚠️ Report is 257 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66075      +/-   ##
==========================================
+ Coverage   90.22%   90.24%   +0.02%     
==========================================
  Files         787      789       +2     
  Lines      270307   271560    +1253     
  Branches    51726    51829     +103     
==========================================
+ Hits       243890   245078    +1188     
- Misses      16899    16928      +29     
- Partials     9518     9554      +36     
Files with missing lines Coverage Δ
lib/internal/worker.js 97.02% <100.00%> (ø)

... and 71 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dayun6530

Copy link
Copy Markdown
Contributor Author

Hi @nodejs/workers, just following up on this PR.
It fixes #65782 by removing messageerror listeners on worker exit and adds a regression test for the cleanup behavior.
The targeted test and make lint-js pass locally.
When someone has a chance, could you please take a look and start CI if appropriate? Thanks!

@daeyeon daeyeon added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 23, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 23, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. labels Sep 25, 2026
@github-actions github-actions Bot removed the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Sep 25, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@daeyeon daeyeon added the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Sep 25, 2026
@github-actions github-actions Bot removed the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Sep 25, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@panva panva added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 26, 2026
@nodejs-github-bot
nodejs-github-bot merged commit d9208cc into nodejs:main Sep 26, 2026
116 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in d9208cc

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 26, 2026
aduh95 pushed a commit that referenced this pull request Sep 27, 2026
Signed-off-by: Dayun <dlekdbs6530@gmail.com>
PR-URL: #66075
Fixes: #65782
Reviewed-By: James M Snell <jasnell@gmail.com>
HoonDongKang pushed a commit to HoonDongKang/node that referenced this pull request Sep 28, 2026
Signed-off-by: Dayun <dlekdbs6530@gmail.com>
PR-URL: nodejs#66075
Fixes: nodejs#65782
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Sep 28, 2026
Signed-off-by: Dayun <dlekdbs6530@gmail.com>
PR-URL: #66075
Fixes: #65782
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. worker Issues and PRs related to the worker_threads module and Worker API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

worker: messageerror listeners remain during exit

5 participants