sqlite: reject plans with unusable virtual table parameters - #66215
Merged
nodejs-github-bot merged 1 commit intoSep 29, 2026
Merged
nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Return SQLITE_CONSTRAINT from xBestIndex() when a hidden column has an equality constraint that is not usable at the current point in the query plan. Accepting such a plan makes xFilter() call rows() with null, silently dropping rows and returning an empty result, e.g. for "SELECT DISTINCT * FROM m(t.a) JOIN t ON t.a = m.a". Cost estimates alone cannot enforce parameter dependencies; rejecting the plan lets SQLite pick an ordering where the parameter value is available. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: opencode
trivikr
force-pushed
the
sqlite-virtual-table-param-unavailable
branch
from
September 23, 2026 00:26
8b0e7cc to
cd29ffe
Compare
trivikr
added
the
request-ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66215 +/- ##
==========================================
- Coverage 90.29% 90.27% -0.02%
==========================================
Files 790 790
Lines 272883 272891 +8
Branches 52118 52108 -10
==========================================
- Hits 246387 246348 -39
- Misses 16943 16996 +53
+ Partials 9553 9547 -6
🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
trivikr
removed
the
request-ci
trivikr
added
author ready
nodejs-github-bot
added
the
lacks-second-approval
Collaborator
|
Landed in 9bf40b2 |
nodejs-github-bot
removed
commit-queue
aduh95
pushed a commit
that referenced
this pull request
Oct 3, 2026
Return SQLITE_CONSTRAINT from xBestIndex() when a hidden column has an equality constraint that is not usable at the current point in the query plan. Accepting such a plan makes xFilter() call rows() with null, silently dropping rows and returning an empty result, e.g. for "SELECT DISTINCT * FROM m(t.a) JOIN t ON t.a = m.a". Cost estimates alone cannot enforce parameter dependencies; rejecting the plan lets SQLite pick an ordering where the parameter value is available. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: opencode PR-URL: #66215 Fixes: #66214 Reviewed-By: Guilherme Araújo <arauujogui@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Oct 3, 2026
Return SQLITE_CONSTRAINT from xBestIndex() when a hidden column has an equality constraint that is not usable at the current point in the query plan. Accepting such a plan makes xFilter() call rows() with null, silently dropping rows and returning an empty result, e.g. for "SELECT DISTINCT * FROM m(t.a) JOIN t ON t.a = m.a". Cost estimates alone cannot enforce parameter dependencies; rejecting the plan lets SQLite pick an ordering where the parameter value is available. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: opencode PR-URL: #66215 Fixes: #66214 Reviewed-By: Guilherme Araújo <arauujogui@gmail.com>
mceachen
added a commit
to photostructure/node-sqlite
that referenced
this pull request
Oct 3, 2026
When a hidden column's equality constraint was not yet usable, xBestIndex() accepted the plan and xFilter() called rows(null), so a query such as SELECT DISTINCT ... FROM vt, t WHERE vt.param = t.a returned no rows. Refs: nodejs/node#66215
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #66214
Return SQLITE_CONSTRAINT from xBestIndex() when a hidden column has an equality constraint that is not usable at the current point in the query plan. Accepting such a plan makes xFilter() call rows() with null, silently dropping rows and returning an empty result, e.g. for "SELECT DISTINCT * FROM m(t.a) JOIN t ON t.a = m.a".
Cost estimates alone cannot enforce parameter dependencies; rejecting the plan lets SQLite pick an ordering where the parameter value is available.
Assisted-by: opencode