Repository navigation
benchmark: remove duplicate ffi string length direct - #66278
Merged
nodejs-github-bot merged 1 commit intoSep 27, 2026
Merged
nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
benchmark
Signed-off-by: HoonDongKang <d159123@naver.com>
HoonDongKang
force-pushed
the
benchmark-remove-duplicate-string-length-direct
branch
from
September 25, 2026 11:59
43b14c6 to
f328905
Compare
daeyeon
approved these changes
Sep 25, 2026
daeyeon
added
author ready
lpinca
approved these changes
Sep 25, 2026
Collaborator
|
Landed in c97bbfb |
nodejs-github-bot
removed
the
commit-queue
aduh95
pushed a commit
that referenced
this pull request
Sep 27, 2026
Signed-off-by: HoonDongKang <d159123@naver.com> PR-URL: #66278 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Sep 28, 2026
Signed-off-by: HoonDongKang <d159123@naver.com> PR-URL: #66278 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
string_lengthFFI benchmark had four cases:string-length-string.jspasses the JavaScript string"hello".string-length-buffer.jspassesBuffer.from('hello\0').string-length-string-direct.jsandstring-length-buffer-direct.jsboth pass a raw pointer obtained withffi.getRawPointer().The two direct benchmarks contained identical code: both created the same Buffer, obtained its raw pointer, and passed that pointer to
string_length. This PR replaces them with a singlestring-length-direct.jsbenchmark so the same case runs only once.