tools: avoid repeated subtree scans in must-call-assert - #66408
Merged
Merged
Conversation
Match the promise call chain before checking for a descendant return statement, preserving the existing lint checks. Assisted-by: Codex Signed-off-by: inoway46 <inoueyuya416@gmail.com>
inoway46
marked this pull request as ready for review
September 30, 2026 08:19
This was referenced Sep 30, 2026
aduh95
approved these changes
Sep 30, 2026
aduh95
added
author ready
nodejs-github-bot
added
the
lacks-second-approval
panva
approved these changes
Oct 3, 2026
Collaborator
|
Landed in a72712b |
nodejs-github-bot
removed
commit-queue
aduh95
pushed a commit
that referenced
this pull request
Oct 3, 2026
Match the promise call chain before checking for a descendant return statement, preserving the existing lint checks. Assisted-by: Codex Signed-off-by: inoway46 <inoueyuya416@gmail.com> PR-URL: #66408 Refs: #64972 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Oct 3, 2026
Match the promise call chain before checking for a descendant return statement, preserving the existing lint checks. Assisted-by: Codex Signed-off-by: inoway46 <inoueyuya416@gmail.com> PR-URL: #66408 Refs: #64972 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match the
.then()/mustCall()call chain before evaluating:has(ReturnStatement), avoiding subtree scans for unrelated nodeswhile preserving the existing lint checks.
Across 256 ubuntu-slim trials per version, the average duration of the
lint-js-and-mdjob from.github/workflows/linters.ymldecreasedfrom 9m03s to 7m32s.
ubuntu-slim(before)ubuntu-slim(after)Runs (64
combined-slimtrials per batch; only this job is included in the table):Refs: #64972