Skip to content

tools: limit format-cpp checkout history - #66479

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
inoway46:format-cpp-checkout-pr
Oct 5, 2026
Merged

nodejs-github-bot merged 1 commit into
nodejs:mainfrom
inoway46:format-cpp-checkout-pr

Conversation

@inoway46

@inoway46 inoway46 commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Fetch only two levels of history for format-cpp and use the PR merge commit's first parent as the formatting base.

In 128 trials per variant on the same merge commit, average checkout time fell from 160.12s to 19.95s. Both variants produced identical bases and diffs.

Runner Success rate Avg Min P90 P99 Max
ubuntu-slim (before) 128/128 (100%) 3m 25s 2m 52s 4m 05s 5m 05s 5m 30s
ubuntu-slim (after) 128/128 (100%) 1m 08s 0m 49s 1m 40s 2m 32s 2m 51s

Benchmark: full = before, shallow = after.

Refs: #64972 (comment)

Use the first parent of the PR merge commit as the formatting base,
allowing a depth-two checkout instead of fetching the full history.

Assisted-by: Codex
Signed-off-by: inoway46 <inoueyuya416@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 3, 2026
@inoway46
inoway46 marked this pull request as ready for review October 3, 2026 11:03
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 3, 2026
@nodejs-github-bot
nodejs-github-bot merged commit c4af866 into nodejs:main Oct 5, 2026
38 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in c4af866

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 5, 2026
aduh95 pushed a commit that referenced this pull request Oct 5, 2026
Use the first parent of the PR merge commit as the formatting base,
allowing a depth-two checkout instead of fetching the full history.

Assisted-by: Codex
Signed-off-by: inoway46 <inoueyuya416@gmail.com>
PR-URL: #66479
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants