Skip to content
Navigation Menu
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Copilot app
Direct agents from issue to merge
MCP Registry
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
Code Quality
Enforce quality at merge
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
View all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
View all resources
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
GitHub Stars
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
nodejs
/
node
Public
Uh oh!
There was an error while loading.
Please reload this page
.
Notifications
You must be signed in to change notification settings
Fork
37.4k
Star
122k
Code
Issues
625
Pull requests
561
Actions
Projects
Security and quality
0
Insights
Additional navigation options
Code
Issues
Pull requests
Actions
Projects
Security and quality
Insights
src: extracting OnConnection from pipe_wrap and tcp_wrap
- #7547
#7547
Closed
danbev
wants to merge 23 commits into
nodejs:master
nodejs/node:master
from
danbev:extracting-onconnection
danbev/node:extracting-onconnection
Copy head branch name to clipboard
Conversation
Commits
23
(23)
Checks
Files changed
Closed
src: extracting OnConnection from pipe_wrap and tcp_wrap
#7547
danbev
wants to merge 23 commits into
nodejs:master
nodejs/node:master
from
danbev:extracting-onconnection
danbev/node:extracting-onconnection
Copy head branch name to clipboard
Commits
Commits on Jul 5, 2016
src: extracting OnConnection from pipe_wrap and tcp_wrap
Show description for ad6dee3
danbev
committed
ad6dee3
View commit details
Copy full SHA for ad6dee3
Browse repository at this point
Commits on Jul 7, 2016
Moving template types to the ConnectionWrap class.
danbev
committed
a3b976e
View commit details
Copy full SHA for a3b976e
Browse repository at this point
Commits on Jul 8, 2016
extracting UVHandle() and handle_ to ConnectionWrap.
Show description for 34d5abc
danbev
committed
34d5abc
View commit details
Copy full SHA for 34d5abc
Browse repository at this point
Commits on Jul 9, 2016
Renaming BaseObject's handle_ to objecthandle_
danbev
committed
564342d
View commit details
Copy full SHA for 564342d
Browse repository at this point
Changing uvhandle_ back to handle_
danbev
committed
623ad2e
View commit details
Copy full SHA for 623ad2e
Browse repository at this point
Removing unnecessary friend class ConnectionWrap
danbev
committed
458accc
View commit details
Copy full SHA for 458accc
Browse repository at this point
Making UVHandle() an inline member function.
danbev
committed
ee0f2b9
View commit details
Copy full SHA for ee0f2b9
Browse repository at this point
Adding a space after template keyword
danbev
committed
5562c45
View commit details
Copy full SHA for 5562c45
Browse repository at this point
Correcting comment changing Instanciate to Instantiate
danbev
committed
ee62109
View commit details
Copy full SHA for ee62109
Browse repository at this point
Adding a null pointer check for wrap_data.
danbev
committed
579f48a
View commit details
Copy full SHA for 579f48a
Browse repository at this point
Adding back spaces to line up macro continuation escape charaters
danbev
committed
1437ec6
View commit details
Copy full SHA for 1437ec6
Browse repository at this point
Removing unnecessary template specializations
danbev
committed
d0da4bc
View commit details
Copy full SHA for d0da4bc
Browse repository at this point
Fixing typo in comment.
danbev
committed
1b3be60
View commit details
Copy full SHA for 1b3be60
Browse repository at this point
Commits on Jul 14, 2016
Lining up arguments for SetWeak method call
danbev
committed
e364ec4
View commit details
Copy full SHA for e364ec4
Browse repository at this point
Renaming objecthandle_ to persistent_handle_
danbev
committed
e8ed621
View commit details
Copy full SHA for e8ed621
Browse repository at this point
Adding a comment to clarify uv_accept error handling
danbev
committed
7ce112a
View commit details
Copy full SHA for 7ce112a
Browse repository at this point
Correcting spelling of unavailable.
danbev
committed
c9ec24d
View commit details
Copy full SHA for c9ec24d
Browse repository at this point
Removing multiple inheritance.
danbev
committed
5ef85f9
View commit details
Copy full SHA for 5ef85f9
Browse repository at this point
Commits on Jul 16, 2016
Making ConnectionWrap inherit from StreamWrap
danbev
committed
ece2d31
View commit details
Copy full SHA for ece2d31
Browse repository at this point
Commits on Jul 17, 2016
Adding a destructor for ConnectionWrap
danbev
committed
73c956d
View commit details
Copy full SHA for 73c956d
Browse repository at this point
Removing unnecessary template parameters for OnConnection
danbev
committed
4feb84a
View commit details
Copy full SHA for 4feb84a
Browse repository at this point
Removing the inclusion of async-wrap.h
danbev
committed
0a1ff38
View commit details
Copy full SHA for 0a1ff38
Browse repository at this point
Commits on Jul 20, 2016
Removing the empty destructor in favour of an explicit default
danbev
committed
85af1a6
View commit details
Copy full SHA for 85af1a6
Browse repository at this point
You can’t perform that action at this time.