Skip to content

Add regex check to error expectation - #9949

Closed
samshull wants to merge 0 commit into
nodejs:masterfrom
samshull:master
Closed

Add regex check to error expectation#9949
samshull wants to merge 0 commit into
nodejs:masterfrom
samshull:master

Conversation

@samshull

@samshull samshull commented Dec 1, 2016

Copy link
Copy Markdown
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

Add regex check to error expectation that matches the expected error message.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Dec 1, 2016
@mscdex

mscdex commented Dec 1, 2016

Copy link
Copy Markdown
Contributor

Please follow the commit message guidelines here.

@mscdex mscdex added the buffer Issues and PRs related to the buffer subsystem. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@samshull

samshull commented Dec 1, 2016

Copy link
Copy Markdown
Author

@mscdex updated explanation

@samshull samshull closed this Dec 1, 2016
@samshull

samshull commented Dec 1, 2016

Copy link
Copy Markdown
Author

Closed in favor of #10038

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

buffer Issues and PRs related to the buffer subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@samshull @mscdex @imyller @nodejs-github-bot