perf(tests): reduce native Git fixture setup cost - #607
Merged
Conversation
Ship integration fixtures started an extra Node process supervisor for every setup Git command. Use direct native execution with a 90-second timeout before test hooks are installed. Actual test commands, hook-dispatching commits and their process-tree cleanup stay supervised. The timeout targets Git directly; no intermediate shell is introduced. Five alternating fixture-phase pairs measured median child CPU **753.844ms → 143.530ms (81.0% less)** and elapsed time **738.727ms → 231.705ms (68.6% less)**, with identical resulting repository state. These are initialization-phase measurements, not a whole-suite speedup claim. The reproducible runner, raw rows, append-only ledger and immutable checkpoints are included; the earlier shell-batch measurement is explicitly superseded. Validation: all 118 focused integration tests passed across ship-fixture, ship-branch, ship-dry-gates and ship-base-and-self-checkout (631.85s). Typecheck, Fallow and the staged benchmark integrity check passed. Publication uses standard devkit ship gates; the full suite runs in PR CI. No gate bypass flags are used.
Contributor
|
Warning Review limit reachedNext included review available in 35 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (14)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ship integration fixtures started an extra Node process supervisor for every setup Git command. Use direct native execution with a 90-second timeout before test hooks are installed. Actual test commands, hook-dispatching commits and their process-tree cleanup stay supervised. The timeout targets Git directly; no intermediate shell is introduced.
Five alternating fixture-phase pairs measured median child CPU 753.844ms → 143.530ms (81.0% less) and elapsed time 738.727ms → 231.705ms (68.6% less), with identical resulting repository state. These are initialization-phase measurements, not a whole-suite speedup claim. The reproducible runner, raw rows, append-only ledger and immutable checkpoints are included; the earlier shell-batch measurement is explicitly superseded.
Validation: all 118 focused integration tests passed across ship-fixture, ship-branch, ship-dry-gates and ship-base-and-self-checkout (631.85s). Typecheck, Fallow and the staged benchmark integrity check passed. Publication uses standard devkit ship gates; the full suite runs in PR CI. No gate bypass flags are used.