Skip to content

fix(i18n): improve Japanese translation for chart alt text#2902

Draft
shuuji3 wants to merge 1 commit into
mainfrom
shuuji3/fix/improve-japanese-translation
Draft

fix(i18n): improve Japanese translation for chart alt text#2902
shuuji3 wants to merge 1 commit into
mainfrom
shuuji3/fix/improve-japanese-translation

Conversation

@shuuji3

@shuuji3 shuuji3 commented Jun 13, 2026

Copy link
Copy Markdown
Member

🔗 Linked issue

N/A

🧭 Context

There was a small error in the download chart alt text transtation where there are two "。" (period equivalent in Japanese) in the middle of the alt text.

📚 Description

  • Fixed the above issue and improve the alt text translation (used more common terminology in the math)
  • Plus, added a new missing translation.

@vercel

vercel Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Jun 13, 2026 4:02pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Jun 13, 2026 4:02pm
npmx-lunaria Ignored Ignored Jun 13, 2026 4:02pm

Request Review

@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 72c96e48-b012-4a35-ba26-64c5574b0736

📥 Commits

Reviewing files that changed from the base of the PR and between 1c48d0c and 7838bec.

📒 Files selected for processing (1)
  • i18n/locales/ja-JP.json

📝 Walkthrough

Summary by CodeRabbit

  • Localisation
    • Updated Japanese language translations for enhanced clarity in trend analysis descriptions
    • Added version label to Japanese language support

Walkthrough

This pull request updates Japanese localization strings in a single file. It adds a version label to package cards and refines trend chart terminology, replacing strong/weak descriptors with ascending/descending labels whilst adjusting accompanying copy text and formatting.

Changes

Japanese Localization Updates

Layer / File(s) Summary
Package card version label
i18n/locales/ja-JP.json
New version translation key ("バージョン") added under the package.card section.
Trend chart labels and copy revision
i18n/locales/ja-JP.json
Trend strength descriptors changed from "強い"/"弱い" (strong/weak) to "上昇"/"下降" (ascending/descending), and analysis and general_description copy adjusted with refined wording and watermark placement.

Possibly related PRs

  • npmx-dev/npmx.dev#2745: Both PRs modify i18n/locales/ja-JP.json with overlapping updates to package.card version label and timeline.trends.chart.copy_alt trend/analysis copy.

Suggested reviewers

  • graphieros
  • ghostdevv
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main changes: fixing and improving Japanese translations for chart alt text, which aligns with the summary showing updates to the timeline.trends.chart.copy_alt block.
Description check ✅ Passed The description is directly related to the changeset, explaining the specific error fixed (duplicate Japanese periods) and improvements made to terminology, matching the actual file changes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch shuuji3/fix/improve-japanese-translation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/ja-JP.json Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov

codecov Bot commented Jun 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@gameroman gameroman added the i18n Related to internationalization label Jun 13, 2026
@trueberryless

Copy link
Copy Markdown
Member

Do you think you could also add the other 36 missing translations keys?

  • shortcuts.open_stats
  • command_palette.package.stats
  • noodles.title
  • noodles.meta_description
  • noodles.latest
  • noodles.what_is
  • noodles.what_is_body
  • noodles.empty
  • noodles.load_more
  • noodles.dates
  • noodles.shipped_in
  • noodles.credits
  • noodles.learn_more
  • noodles.carousel_prev
  • noodles.carousel_next
  • noodles.carousel_dots
  • noodles.carousel_jump
  • noodles.lens_label
  • noodles.lens_slide
  • noodles.lens_slide_position
  • noodles.back_to_archive
  • noodles.missing.title
  • noodles.missing.body
  • package.replacement.simple
  • package.replacement.documented
  • package.stats.main_information
  • package.stats.trends
  • package.stats.version_distribution
  • package.links.stats
  • package.trends.embedding.chart
  • package.trends.embedding.copy_url
  • package.trends.embedding.preview
  • package.trends.embedding.tip
  • compare.diff_truncated

(package.card.version was already added in this PR)

@shuuji3

shuuji3 commented Jun 14, 2026

Copy link
Copy Markdown
Member Author

Oh, I tried https://npmx.dev/translation-status for the first time and I thought there is only one missing key, but this page actually reflects the only stable version? 🤔

screenshot of status page: 'ja-JP 1 missing translation'

Anyway, I'm going to translate them all soon today.

@shuuji3 shuuji3 marked this pull request as draft June 14, 2026 01:57
@trueberryless

Copy link
Copy Markdown
Member

Oh, I tried https://npmx.dev/translation-status for the first time and I thought there is only one missing key, but this page actually reflects the only stable version? 🤔

screenshot of status page: 'ja-JP 1 missing translation'

Yeah, unfortunately the current state from main doesn't load under https://main.npmx.dev/translation-status, so you have to work with our i18n commands to be sure...

I ran node scripts/compare-translations.ts ja-JP to get the output 👍

@graphieros graphieros left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Related to internationalization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants