Skip to content

fix: align package selection checkbox - #3258

Merged
graphieros merged 1 commit into
npmx-dev:mainfrom
szymonchudy:fix/package-selection-checkbox-alignment
Sep 17, 2026
Merged

graphieros merged 1 commit into
npmx-dev:mainfrom
szymonchudy:fix/package-selection-checkbox-alignment

Conversation

@szymonchudy

Copy link
Copy Markdown
Contributor

🧭 Context

While working on #3257 I've noticed that the package selection checkbox appears slightly vertically misaligned when it becomes visible on row hover in the organization package list.

Before

CleanShot 2026-09-17 at 06 34 43@2x

After

CleanShot 2026-09-17 at 06 38 16@2x

📚 Description

Use flex alignment on the checkbox label so the native checkbox is centered within its label, rather than following the browser's default inline text baseline.

@agentscanapp

agentscanapp Bot commented Sep 17, 2026

Copy link
Copy Markdown

Thanks for opening this pull request! 🎉

We really appreciate you taking the time to contribute, @szymonchudy.

A maintainer will take a look as soon as they can. In the meantime, please make sure that:

  • the description explains what changed and why
  • any related issues are linked
  • existing tests still pass

If anything needs adjusting we'll leave comments here. Thanks again!

@vercel

vercel Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
npmx.dev Ready Ready Preview Sep 17, 2026 5:07am UTC
2 Skipped Deployments
Project Deployment Actions Updated
docs.npmx.dev Ignored Ignored Preview Sep 17, 2026 5:07am UTC
npmx-lunaria Ignored Ignored Sep 17, 2026 5:07am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 8b08c516-e028-4fc9-827f-5fd3c0246ac4

📥 Commits

Reviewing files that changed from the base of the PR and between 08b6efc and 3d78992.

📒 Files selected for processing (1)
  • app/components/Package/SelectionCheckbox.vue

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Style
    • Improved checkbox alignment by centring the checkbox and its label content in a horizontal layout.

Walkthrough

The checkbox label now uses flex items-center classes. Its contents render in a centred flex row.

Changes

Checkbox layout

Layer / File(s) Summary
Align checkbox label contents
app/components/Package/SelectionCheckbox.vue
The <label> wrapper gains flex items-center classes.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 3d789

The checkbox alignment update is localized and does not introduce an identified user-facing or runtime risk.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: fixing the alignment of the package selection checkbox.
Description check ✅ Passed The description directly explains the checkbox alignment issue and the flex alignment change that resolves it.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@graphieros graphieros left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌿

@graphieros
graphieros added this pull request to the merge queue Sep 17, 2026
Merged via the queue into npmx-dev:main with commit af2c261 Sep 17, 2026
25 checks passed
@github-actions

Copy link
Copy Markdown

Thanks for your first contribution, @szymonchudy! 🤩

We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants