fix(release): don't abort nightly publish loop on a single package failure - #1087
fix(release): don't abort nightly publish loop on a single package failure#1087antfubot wants to merge 1 commit into
Conversation
Deploying nuxt-devtools with
|
| Latest commit: |
e458784
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3b861fd0.nuxt-devtools.pages.dev |
| Branch Preview URL: | https://fix-nightly-release-loop.nuxt-devtools.pages.dev |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe nightly release script now continues after individual Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Nightly publishing now continues after an individual package publish failure while still reporting failures through a nonzero exit status. The change is ready to merge with no identified release-behavior risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Nightly releases have been broken for
devtools-kitanddevtools-ui-kitsincepackages/devtools-assetswas added: the release script loops overpackages/*underset -e, so when@nuxt/devtools-assets-nightly404s on publish (npm trusted publishing was never bootstrapped for that new package name), the whole script aborts mid-loop and every package alphabetically after it silently stops receiving nightly publishes.This makes the publish loop resilient to a single package's failure: each package is still attempted, failures are collected, and the script exits non-zero at the end only if any package failed — so
devtools-kit-nightlyanddevtools-ui-kit-nightlyresume publishing whiledevtools-assets-nightlystill surfaces as needing its npm trusted-publisher setup (a one-time action on npmjs.com, outside this repo).Created with the help of an AI agent.