Skip to content

fix(release): don't abort nightly publish loop on a single package failure - #1087

Closed
antfubot wants to merge 1 commit into
mainfrom
fix/nightly-release-loop
Closed

fix(release): don't abort nightly publish loop on a single package failure#1087
antfubot wants to merge 1 commit into
mainfrom
fix/nightly-release-loop

Conversation

@antfubot

@antfubot antfubot commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Nightly releases have been broken for devtools-kit and devtools-ui-kit since packages/devtools-assets was added: the release script loops over packages/* under set -e, so when @nuxt/devtools-assets-nightly 404s on publish (npm trusted publishing was never bootstrapped for that new package name), the whole script aborts mid-loop and every package alphabetically after it silently stops receiving nightly publishes.

This makes the publish loop resilient to a single package's failure: each package is still attempted, failures are collected, and the script exits non-zero at the end only if any package failed — so devtools-kit-nightly and devtools-ui-kit-nightly resume publishing while devtools-assets-nightly still surfaces as needing its npm trusted-publisher setup (a one-time action on npmjs.com, outside this repo).


Created with the help of an AI agent.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying nuxt-devtools with  Cloudflare Pages  Cloudflare Pages

Latest commit: e458784
Status: ✅  Deploy successful!
Preview URL: https://3b861fd0.nuxt-devtools.pages.dev
Branch Preview URL: https://fix-nightly-release-loop.nuxt-devtools.pages.dev

View logs

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 594eeea3-de4e-41fe-96ea-3a59fd4ebcf3

📥 Commits

Reviewing files that changed from the base of the PR and between e42176c and e458784.

📒 Files selected for processing (1)
  • scripts/release-nightly.sh

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The nightly release script now continues after individual pnpm publish failures. It records failed package paths while it processes the remaining packages. After the loop completes, it reports the failures and exits with status 1. Successful publishing behavior remains unchanged.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to e4587

Nightly publishing now continues after an individual package publish failure while still reporting failures through a nonzero exit status. The change is ready to merge with no identified release-behavior risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: allowing the nightly publish loop to continue after a single package failure.
Description check ✅ Passed The description directly explains the publish-loop failure, the affected packages, and the new failure-reporting behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/nightly-release-loop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@antfu antfu closed this Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants