This repository was archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt): mark config head as non-reactive - #4666
Merged
Merged
Conversation
✅ Deploy Preview for nuxt3-docs canceled.
|
pi0
approved these changes
Apr 29, 2022
Merged
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves nuxt/nuxt#13397, resolves nuxt/nuxt#13847
❓ Type of change
📚 Description
In general using reactive objects outside of a Vue context is dangerous. This PR marks the nuxt configuration head inserted by Nuxt as non-reactive, which avoids a memory leak, as well as tidying up a bit of leftover bridge compatibility.
There seems ample space here for future improvement as well, including:
vueuse/headimplementation (or in our practice of reffing up the head values)useHeadis being called outside of a vue context (that is, in a plugin) and marking entries as non-reactive if they aren't already refs/reactive.📝 Checklist