Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(kit, nuxt): always sort globby results - #6029

Merged
pi0 merged 1 commit into
mainfrom
fix/stable-globby
Jul 21, 2022
Merged

fix(kit, nuxt): always sort globby results#6029
pi0 merged 1 commit into
mainfrom
fix/stable-globby

Conversation

@antfu

@antfu antfu commented Jul 21, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

The order of the result from globby is not reliable. This will potentially cause the order of installed plugins/modules to be unstable across multiple builts or on different machines. We should always sort them to make it stable.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlify Bot commented Jul 21, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

Name Link
🔨 Latest commit 12cdb66
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62d91ee1feedb5000a7187af
😎 Deploy Preview https://deploy-preview-6029--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0 pi0 changed the title fix: stable globby scan fix(kit, nuxt): always sort globby results Jul 21, 2022

@pi0 pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@pi0
pi0 merged commit b4b9804 into main Jul 21, 2022
@pi0
pi0 deleted the fix/stable-globby branch July 21, 2022 10:46
@pi0 pi0 mentioned this pull request Aug 5, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants