Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): separate routes for different suspense forks - #6275

Merged
pi0 merged 3 commits into
mainfrom
fix/suspended-routes
Aug 2, 2022
Merged

fix(nuxt): separate routes for different suspense forks#6275
pi0 merged 3 commits into
mainfrom
fix/suspended-routes

Conversation

@danielroe

@danielroe danielroe commented Aug 1, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

resolves nuxt/nuxt#14456

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR provides the current route directly at the point of suspense, meaning within the context of a suspense fork, the route will not change until suspense has resolved. We also update the default useRoute behaviour to mean that the route will not change outside of a page context until suspense has resolved.

Context: #4124, nuxt/nuxt#13630, #4092.


Previous behaviour:

CleanShot 2022-08-01 at 09 50 46

New behaviour:

CleanShot 2022-08-01 at 09 51 37

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working pages labels Aug 1, 2022
@danielroe danielroe self-assigned this Aug 1, 2022
@netlify

netlify Bot commented Aug 1, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 5b2fecf
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62e79f2fd02cac0008ab631f

@danielroe
danielroe requested a review from pi0 August 1, 2022 09:06
Comment thread packages/nuxt/src/pages/runtime/router.ts Outdated

@atinux atinux left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ❤️

@pi0 pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. All seems great!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x bug Something isn't working pages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

route updates before suspense resolves

4 participants