Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

test: add key matching test for keyed composables - #6372

Merged
pi0 merged 2 commits into
mainfrom
test/keyed-composables
Aug 5, 2022
Merged

test: add key matching test for keyed composables#6372
pi0 merged 2 commits into
mainfrom
test/keyed-composables

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Adds some extra tests to protect against nuxt/nuxt#14442. See also #6191.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the test label Aug 5, 2022
@danielroe
danielroe requested a review from pi0 August 5, 2022 08:16
@danielroe danielroe self-assigned this Aug 5, 2022
@netlify

netlify Bot commented Aug 5, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit f51a040
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62ecf066d6d667000a513150

@pi0

pi0 commented Aug 5, 2022

Copy link
Copy Markdown
Member

(windows test seems failing. retrying CI)

@danielroe

Copy link
Copy Markdown
Member Author

Checking on a Windows system to see if it's revealed an actual issue.

@danielroe

danielroe commented Aug 5, 2022

Copy link
Copy Markdown
Member Author

Just to update: this seems a strange Vue core bug - the mismatch is actually between \r on client and \r\n on server. 🤦 Still investigating.

@danielroe

Copy link
Copy Markdown
Member Author

~> vuejs/core#6410

@danielroe
danielroe requested a review from pi0 August 5, 2022 10:54
@pi0
pi0 merged commit 07fa104 into main Aug 5, 2022
@pi0
pi0 deleted the test/keyed-composables branch August 5, 2022 11:02
@pi0 pi0 mentioned this pull request Aug 9, 2022
@mercs600

mercs600 commented Oct 6, 2022

Copy link
Copy Markdown

@danielroe vue fixed this bug, can we upgrade vue dependency ?

@danielroe

Copy link
Copy Markdown
Member Author

You don't need Nuxt to update to benefit from a new Vue release. Just upgrade it with npm upgrade vue or your package manager's equivalent.

We use a caret for this reason. https://github.com/nuxt/framework/blob/main/packages/nuxt/package.json#L75

@mercs600

mercs600 commented Oct 6, 2022

Copy link
Copy Markdown

Thats right, I have done it, thank you

@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants