Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): routerBehavior comparison for hash block - #8383

Merged
pi0 merged 1 commit into
nuxt:mainfrom
jiblett1000:nuxt-link-hash
Oct 21, 2022
Merged

fix(nuxt): routerBehavior comparison for hash block#8383
pi0 merged 1 commit into
nuxt:mainfrom
jiblett1000:nuxt-link-hash

Conversation

@jiblett1000

@jiblett1000 jiblett1000 commented Oct 21, 2022

Copy link
Copy Markdown
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Unless I'm mistaken, the comparison made here should be checking if the routes are === and not !==. Before, the hash logic wasn't reachable.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox

codesandbox Bot commented Oct 21, 2022

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlify Bot commented Oct 21, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

Name Link
🔨 Latest commit 536925c
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6352540437356e00096f2a5b
😎 Deploy Preview https://deploy-preview-8383--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jiblett1000 jiblett1000 changed the title fix: route comparison for hashes fix(nuxt): route comparison for hashes Oct 21, 2022
@jiblett1000 jiblett1000 changed the title fix(nuxt): route comparison for hashes fix(nuxt): routerBehavior comparison for hash block Oct 21, 2022

@pi0 pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spot!

@pi0
pi0 merged commit a0a59e2 into nuxt:main Oct 21, 2022
@pi0 pi0 mentioned this pull request Nov 3, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants