This repository was archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt): improve hmr for pages macros - #8940
Merged
Merged
Conversation
|
|
✅ Deploy Preview for nuxt3-docs canceled.
|
danielroe
reviewed
Nov 14, 2022
danielroe
left a comment
danielroe
left a comment
Member
There was a problem hiding this comment.
thank you so much for looking at this ❤️
Merged
danielroe
force-pushed
the
fix/pages-hmr
branch
from
November 15, 2022 10:11
ba31e9e to
f7f0a95
Compare
danielroe
reviewed
Nov 15, 2022
Comment on lines
+22
to
+35
| if (process.dev) { | ||
| // Vite | ||
| if (import.meta.hot) { | ||
| import.meta.hot.accept(mod => { | ||
| Object.assign(__nuxt_page_meta, mod) | ||
| }) | ||
| } | ||
| // Webpack | ||
| if (import.meta.webpackHot) { | ||
| import.meta.webpackHot.accept((err) => { | ||
| if (err) { window.location = window.location.href } | ||
| }) | ||
| } | ||
| }` |
Member
There was a problem hiding this comment.
updated to add webpack equivalent, but I was not able to test this as it seems that no HMR updates are triggered for page meta - am I doing something wrong @antfu?
danielroe
approved these changes
Nov 15, 2022
pi0
changed the title
pi0
approved these changes
Nov 15, 2022
danielroe
added a commit
that referenced
this pull request
Jan 21, 2023
Co-authored-by: Daniel Roe <daniel@roe.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
close nuxt/nuxt#15410
❓ Type of change
📚 Description
📝 Checklist