Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

refactor(kit)!: remove support for module container - #9010

Merged
pi0 merged 3 commits into
mainfrom
refactor/container
Nov 15, 2022
Merged

refactor(kit)!: remove support for module container#9010
pi0 merged 3 commits into
mainfrom
refactor/container

Conversation

@danielroe

@danielroe danielroe commented Nov 15, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

#8994

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR removes automatic provision of module container to nuxt modules.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added enhancement New feature or request kit labels Nov 15, 2022
@danielroe
danielroe requested a review from pi0 November 15, 2022 13:01
@danielroe danielroe self-assigned this Nov 15, 2022
@codesandbox

codesandbox Bot commented Nov 15, 2022

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlify Bot commented Nov 15, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt3-docs ready!

Name Link
🔨 Latest commit a9c1d04
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/637390470f8fa10008a92fd4
😎 Deploy Preview https://deploy-preview-9010--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel
vercel Bot temporarily deployed to Preview November 15, 2022 13:02 Inactive
Comment thread packages/kit/src/module/container.ts Outdated
@danielroe
danielroe requested a review from pi0 November 15, 2022 13:12
@danielroe danielroe mentioned this pull request Nov 15, 2022
@vercel
vercel Bot temporarily deployed to Preview November 15, 2022 13:19 Inactive
@pi0
pi0 merged commit 74b81bb into main Nov 15, 2022
@pi0
pi0 deleted the refactor/container branch November 15, 2022 13:22
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x enhancement New feature or request kit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants