Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

docs: use layout in example of definePageMeta - #9322

Merged
danielroe merged 1 commit into
nuxt:mainfrom
falko-apheris:patch-1
Nov 25, 2022
Merged

docs: use layout in example of definePageMeta#9322
danielroe merged 1 commit into
nuxt:mainfrom
falko-apheris:patch-1

Conversation

@falko-apheris

@falko-apheris falko-apheris commented Nov 25, 2022

Copy link
Copy Markdown
Contributor

The main example showed the usage of the title parameter which is not part of the definePageMeta interface. The example should reflect real values since in the current example it easy to confuse it with useHead which must actually be used to set the page title using the title parameter.

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

The main example showed the usage of the `title` parameter which is not part of the `definePageMeta` interface. The example should reflect real values since in the current example it easy to confuse it with `useHead` which must actually be used to set the page title using the `title` parameter.
@codesandbox

codesandbox Bot commented Nov 25, 2022

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good suggestion 👍

@danielroe danielroe changed the title Use exising parameter in main example of definePageMeta docs: use layout in example of definePageMeta Nov 25, 2022
@danielroe
danielroe merged commit cbf8976 into nuxt:main Nov 25, 2022
@pi0 pi0 mentioned this pull request Dec 15, 2022
6 tasks
@danielroe danielroe added the 3.x label Jan 19, 2023
@danielroe danielroe mentioned this pull request Jan 20, 2023
danielroe pushed a commit that referenced this pull request Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants