Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

docs: change app-config url to avoid naming conflicts with app.vue - #9377

Merged
pi0 merged 2 commits into
mainfrom
docs/fix/naming-conflicts
Nov 28, 2022
Merged

docs: change app-config url to avoid naming conflicts with app.vue#9377
pi0 merged 2 commits into
mainfrom
docs/fix/naming-conflicts

Conversation

@clemcode

Copy link
Copy Markdown
Contributor

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

app.config and app URLs were conflicting in the directory structure section causing a blank page. Renaming to app-config for URLs.

@clemcode
clemcode requested a review from atinux November 28, 2022 12:21
@codesandbox

codesandbox Bot commented Nov 28, 2022

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@pi0

pi0 commented Nov 28, 2022

Copy link
Copy Markdown
Member

Is it something we might track for content/docus and fix later to support dot in content paths? /cc @farnabaz

@vercel
vercel Bot temporarily deployed to Preview November 28, 2022 12:35 Inactive
@atinux

atinux commented Nov 28, 2022

Copy link
Copy Markdown
Member

I think it has to be directly with content since this theme does not use Docus.

Also, we need to improve the Docs Aside to fix the highlight @clemcode (but in another release of the website-theme)

CleanShot 2022-11-28 at 13.45.50@2x.png

@atinux

atinux commented Nov 28, 2022

Copy link
Copy Markdown
Member

Merging since it fixes a broken page for now.

@pi0
pi0 merged commit 65f3b3a into main Nov 28, 2022
@pi0
pi0 deleted the docs/fix/naming-conflicts branch November 28, 2022 12:47
@TheAlexLichter

Copy link
Copy Markdown
Member

Please do not forget to set up redirects, even if temporary!

@atinux

atinux commented Nov 28, 2022

Copy link
Copy Markdown
Member

Was going to push it but done directly on main: 66efcd5

Thanks @manniL

@pi0 pi0 mentioned this pull request Dec 15, 2022
6 tasks
@danielroe danielroe added the 3.x label Jan 19, 2023
@danielroe danielroe mentioned this pull request Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants