Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

feat(nuxt): support for extending error.vue in layers - #9521

Merged
danielroe merged 5 commits into
nuxt:mainfrom
TheAlexLichter:fix/error-layers
Dec 6, 2022
Merged

feat(nuxt): support for extending error.vue in layers#9521
danielroe merged 5 commits into
nuxt:mainfrom
TheAlexLichter:fix/error-layers

Conversation

@TheAlexLichter

@TheAlexLichter TheAlexLichter commented Dec 5, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

Resolves nuxt/nuxt#15717
Related: nuxt/nuxt#13367

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Adds layer/extends support for error.vue

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox

codesandbox Bot commented Dec 5, 2022

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

Comment thread packages/nuxt/src/core/app.ts Outdated
Comment thread packages/nuxt/src/core/app.ts Outdated
@TheAlexLichter

Copy link
Copy Markdown
Member Author

I'll refactor the rest of the file in another PR to make use of pathe.join + keeping fallback out of findPath - for e.g. App.vue

@TheAlexLichter
TheAlexLichter requested a review from pi0 December 5, 2022 15:19
Comment thread packages/nuxt/src/core/app.ts Outdated
Co-authored-by: Daniel Roe <daniel@roe.dev>

@danielroe danielroe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - thank you! ❤️

@danielroe danielroe changed the title feat(layers): support for error.vue feat(nuxt): support for extending error.vue in layers Dec 6, 2022
@danielroe
danielroe merged commit 5f935aa into nuxt:main Dec 6, 2022
@TheAlexLichter
TheAlexLichter deleted the fix/error-layers branch December 6, 2022 10:05
@pi0 pi0 mentioned this pull request Dec 15, 2022
6 tasks
@danielroe danielroe added the 3.x label Jan 19, 2023
@danielroe danielroe mentioned this pull request Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

resolve error.vue in nuxt layers

4 participants