This repository was archived by the owner on Apr 6, 2023. It is now read-only.
docs(rendering): hide light image in dark mode - #9620
Merged
Conversation
|
|
|
@mst101 is attempting to deploy a commit to the Nuxt Team on Vercel. A member of the Team first needs to authorize it. |
danielroe
approved these changes
Dec 10, 2022
danielroe
reviewed
Dec 10, 2022
danielroe
reviewed
Dec 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
The page at https://nuxt.com/docs/guide/concepts/rendering shows both light and dark versions of the images. I don't know how to conditionally render an image from within markdown(?), but this PR at least hides the light version of the image when dark mode is set by simply adding a tailwind class of
dark:hidden.N.B. I'm not sure what the current classes of
.light-imgand.dark-imgcurrently do, if anything?📝 Checklist