Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): remove deprecated req/res access - #9636

Merged
danielroe merged 2 commits into
mainfrom
refactor/deprecated-node
Dec 10, 2022
Merged

fix(nuxt): remove deprecated req/res access#9636
danielroe merged 2 commits into
mainfrom
refactor/deprecated-node

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

A few missing places where we should update to event.node rather than accessing res/req directly off the event

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Dec 9, 2022
@danielroe
danielroe requested a review from pi0 December 9, 2022 22:39
@danielroe danielroe self-assigned this Dec 9, 2022
@codesandbox

codesandbox Bot commented Dec 9, 2022

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe changed the title fix(nuxt): access req/res from event.node fix(nuxt): remove deprecated req/res access Dec 10, 2022
@danielroe
danielroe merged commit 2396fc6 into main Dec 10, 2022
@danielroe
danielroe deleted the refactor/deprecated-node branch December 10, 2022 19:54
@pi0 pi0 mentioned this pull request Dec 15, 2022
6 tasks
@danielroe danielroe added the 3.x label Jan 19, 2023
@danielroe danielroe mentioned this pull request Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x bug Something isn't working 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants