Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

refactor(nuxt): remove vue-meta for head support - #9638

Merged
pi0 merged 2 commits into
nuxt:mainfrom
harlan-zw:refactor/drop-vue-meta
Dec 12, 2022
Merged

refactor(nuxt): remove vue-meta for head support#9638
pi0 merged 2 commits into
nuxt:mainfrom
harlan-zw:refactor/drop-vue-meta

Conversation

@harlan-zw

@harlan-zw harlan-zw commented Dec 10, 2022

Copy link
Copy Markdown
Collaborator

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Originally it seemed like multiple head providers were going to be supported, however with the 3.0 release it seems safe to presume that vue-meta won't be supported in the core anytime soon.

This PR removes vue-meta code, it doesn't introduce any breaking changes (afaik) as there was no way to actually switch to using vue-meta.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox

codesandbox Bot commented Dec 10, 2022

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@vercel

vercel Bot commented Dec 10, 2022

Copy link
Copy Markdown

@harlan-zw is attempting to deploy a commit to the Nuxt Team on Vercel.

A member of the Team first needs to authorize it.

@harlan-zw harlan-zw changed the title refactor(nuxt): drop vue-meta refactor(head): drop vue-meta Dec 10, 2022
@harlan-zw harlan-zw changed the title refactor(head): drop vue-meta refactor(head): remove vue-meta Dec 10, 2022
@pi0 pi0 changed the title refactor(head): remove vue-meta refactor(nuxt): remove vue-meta for head support Dec 12, 2022
@pi0
pi0 merged commit 4cb7e42 into nuxt:main Dec 12, 2022
@pi0

pi0 commented Dec 12, 2022

Copy link
Copy Markdown
Member

Thanks!

@pi0 pi0 mentioned this pull request Dec 15, 2022
6 tasks
@danielroe danielroe added the 3.x label Jan 19, 2023
@danielroe danielroe mentioned this pull request Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants