Skip to content

chore(deps): replace tsconfck with get-tsconfig - #777

Merged
danielroe merged 5 commits into
nuxt:mainfrom
JustusBaumhove:chore/replace-tsconfck-with-get-tsconfig
Aug 11, 2026
Merged

chore(deps): replace tsconfck with get-tsconfig#777
danielroe merged 5 commits into
nuxt:mainfrom
JustusBaumhove:chore/replace-tsconfck-with-get-tsconfig

Conversation

@JustusBaumhove

Copy link
Copy Markdown
Contributor

🔗 Linked issue

Mentioned in #3

📚 Description

tsconfck is unmaintained, this PR swaps it for get-tsconfig. The only usage was loadTSCompilerOptions in src/commands/build.ts.

What changed:

  • parse()getTsconfig(), which performs the same upward search for the nearest config and merges extends.
  • tsconfck exposed the full extends chain via extended[], which meant walking that chain manually to re-anchor each relative paths target against the directory of the config that declared it. get-tsconfig instead flattens extends into a single config and tracks the declaring directory internally, with createPathsMatcher() as the public API that applies it, so the library now handles what was previously done by hand.
  • get-tsconfig is synchronous, so loadTSCompilerOptions is no longer async.

No behaviour change intended.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2032c94d-745a-4b1c-8c30-d8ea9ac01141

📥 Commits

Reviewing files that changed from the base of the PR and between 8d80a3d and 940239d.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • package.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • package.json

📝 Walkthrough

Walkthrough

The build configuration resolver replaces tsconfck with get-tsconfig and createPathsMatcher. loadTSCompilerOptions is now synchronous, returns compiler options from the resolved TypeScript configuration, and remaps path aliases. The mkdist and Rollup hooks invoke it without await. The dependency list is updated accordingly.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes replacing the tsconfck dependency with get-tsconfig.
Description check ✅ Passed The description directly explains the dependency replacement and the related build.ts changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Jul 30, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/module-builder@777

commit: 940239d

@danielroe danielroe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@danielroe
danielroe merged commit eb2367e into nuxt:main Aug 11, 2026
9 checks passed
@JustusBaumhove
JustusBaumhove deleted the chore/replace-tsconfck-with-get-tsconfig branch August 11, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants