feat: update references of tsserver to ts_ls#1131
Merged
Merged
Conversation
| -- But for many setups, the LSP (`tsserver`) will work just fine | ||
| -- tsserver = {}, | ||
| -- But for many setups, the LSP (`ts_ls`) will work just fine | ||
| -- ts_ls = {}, |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
Author
There was a problem hiding this comment.
You're right, I missed that 😵
It should remain tsserver in case anyone uncomments it
|
this is ready to merge as mason also renamed tsserver to ts_ls |
Contributor
|
this should be added as soon as possible |
Contributor
Author
|
Mason updated I've updated the commit to remove the fix and only update every reference of |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nvim-lspconfig renamed
tsservertots_ls(see this PR)This causes a warning everytime you start nvim because Mason hasn't changed
tsservername tots_ls.This PR fixes it by adding an if statement to check if the server name is
tsserverand updates it tots_lsinmason-lspconfig.setup(Credits)Also it replaces every reference of
tsservertots_ls