Set breakpoint icons and their highlight colors#1194
Conversation
|
I think this should be a overall comment that users can uncomment if they want this change. |
| vim.api.nvim_set_hl(0, 'Break', { fg = '#e51400' }) | ||
| vim.api.nvim_set_hl(0, 'Stop', { fg = '#ffcc00' }) | ||
| local breakpoint_icons = vim.g.have_nerd_font | ||
| and { Breakpoint = '', BreakpointCondition = '', BreakpointRejected = '', LogPoint = '', Stopped = '' } |
There was a problem hiding this comment.
I think it be better to just have one table of icons
There was a problem hiding this comment.
Thank you for reviewing the code. With all due respect, that might not be possible.
If vim.g.have_nerd_font is false, the local variable breakpoint_icons would no longer exist.
Error that occurs when deleting the line:
Cannot assign `boolean|table` to parameter `<T:table>`.
- `boolean` cannot match `table`
- Type `boolean` cannot match `table` [param-type-mismatch]
feat: "Break" and "Stop" arguments of vim.api.nvim_set_hl are changed because they are too common nouns feat: Comment out changes regarding diagnostic symbols so that only those who want to change them can do so
|
Hi guys I have no feelings on this. @iton0 Can you help me understand why you think this should just be optional? Do you use/do other people use different conditional break symbols? |
|
I appreciate the overall addition, but I wanted to make it optional for caution's sake. This way, users can experience the default debugging setup first and choose to add features if they wish, rather than having to remove anything. |
|
Ah I failed to notice it's already commented out. merging! |
3 participants
Set breakpoint icons and their highlight colors in
lua/kickstart/plugins/debug.lua; see Here for details