Propsed fix for init.lua warnings without disabling diagnostics#1354
Conversation
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
| @@ -675,6 +675,8 @@ require('lazy').setup({ | |||
| require('mason-tool-installer').setup { ensure_installed = ensure_installed } | |||
|
|
|||
| require('mason-lspconfig').setup { | |||
There was a problem hiding this comment.
setup_handlers() could also be used instead of setup(). See :h mason-lspconfig.setup_handlers()
There was a problem hiding this comment.
Thank you I'll look into that.
Do you have any thoughts on the key point from the issue about the concerns that turning off auto-install might break something?
There was a problem hiding this comment.
AFAIK, mason-lspconfig just merges the user-config with a table containing default values. For automatic_installation that default value seems to be false. So auto-install is already implicitly disabled.
|
Lots of good commentary here, and thanks for all of it! Unless I hear "Don't merge this. You'll break the world!" I'm going to merge tomorrow, because people keep opening bugs against these warnings and it really would be great to silence them :) |
|
Hi |
3 participants
Proposed fix as per #1305 (comment)
FOLKS SHOULD TEST THIS THOROUGHLY. I'm not having any issues but I'd love more feedback please.
NOTE
Please verify that the
base repositoryabove has the intended destination!Github by default opens Pull Requests against the parent of a forked repository.
If this is your personal fork and you didn't intend to open a PR for contribution
to the original project then adjust the
base repositoryaccordingly.