Switch cmp up mapping from C-d to C-b to match regular vim up key#549
Conversation
|
Hi. If you wish to see this merged, please do the following:
Otherwise, if I see a number of folks in the community voicing opinions one way or another on this I'm happy to act accordingly. I'm just concerned about unilateral changes to key mappings which might result in a thousand silent users having their workflow blow up. Thanks for understanding and thanks for your contribution! |
|
Welp, looks like this keybinding has been around since kickstart.nvim was started. I'm guessing it was originally based on nvim-cmp's README, which was eventually fixed in hrsh7th/nvim-cmp#538. |
|
Hey, thanks much for doing that detective work! If it's been fixed in cmp upstream, I'm WAY more tempted to just merge it. Let's give it a few hours in case anyone has any vehement objections and I'll merge this. Thanks! |
|
I agree with the proposed change since it matches with cmp readme. |
Switch cmp up mapping from C-d to C-b to match regular vim up key (nvim-lua#549)
Switch cmp up mapping from C-d to C-b to match regular vim up key (nvim-lua#549)
Switch cmp up mapping from C-d to C-b to match regular vim up key (nvim-lua#549)
See nvim-lua/kickstart.nvim#549 for details
The existing keybinding seems like a typo, since C-d in vim normally scrolls downwards, but C-b scrolls upwards, which seems like the more accurate opposite of C-f.