Skip to content

Switch cmp up mapping from C-d to C-b to match regular vim up key#549

Merged
feoh merged 1 commit into
nvim-lua:masterfrom
aripollak:cmp-scroll
Dec 21, 2023
Merged

Switch cmp up mapping from C-d to C-b to match regular vim up key#549
feoh merged 1 commit into
nvim-lua:masterfrom
aripollak:cmp-scroll

Conversation

@aripollak

@aripollak aripollak commented Dec 20, 2023

Copy link
Copy Markdown
Contributor

The existing keybinding seems like a typo, since C-d in vim normally scrolls downwards, but C-b scrolls upwards, which seems like the more accurate opposite of C-f.

@feoh

feoh commented Dec 20, 2023

Copy link
Copy Markdown
Collaborator

Hi. If you wish to see this merged, please do the following:

  • Look through git history/git blame and find whoever checked in the key mapping you want to change.
  • @ that person in a comment here and ask them whether or not they agree with this change.

Otherwise, if I see a number of folks in the community voicing opinions one way or another on this I'm happy to act accordingly.

I'm just concerned about unilateral changes to key mappings which might result in a thousand silent users having their workflow blow up.

Thanks for understanding and thanks for your contribution!

@aripollak

Copy link
Copy Markdown
Contributor Author

Welp, looks like this keybinding has been around since kickstart.nvim was started. I'm guessing it was originally based on nvim-cmp's README, which was eventually fixed in hrsh7th/nvim-cmp#538.
@tjdevries, do you agree with this change?

@feoh

feoh commented Dec 20, 2023

Copy link
Copy Markdown
Collaborator

Hey, thanks much for doing that detective work!

If it's been fixed in cmp upstream, I'm WAY more tempted to just merge it.

Let's give it a few hours in case anyone has any vehement objections and I'll merge this.

Thanks!

@dam9000

dam9000 commented Dec 20, 2023

Copy link
Copy Markdown
Contributor

I agree with the proposed change since it matches with cmp readme.

@feoh feoh merged commit e39a8bc into nvim-lua:master Dec 21, 2023
Akstrov added a commit to Akstrov/kickstart.nvim that referenced this pull request Dec 22, 2023
Switch cmp up mapping from C-d to C-b to match regular vim up key (nvim-lua#549)
OuthBack added a commit to OuthBack/kickstart-pt-br.nvim that referenced this pull request Dec 23, 2023
Switch cmp up mapping from C-d to C-b to match regular vim up key (nvim-lua#549)
vincentsegard added a commit to vincentsegard/neovim-config that referenced this pull request Dec 23, 2023
Switch cmp up mapping from C-d to C-b to match regular vim up key (nvim-lua#549)
Daedrus added a commit to Daedrus/configfiles that referenced this pull request Dec 25, 2023
Wisien999 pushed a commit to Wisien999/nvim-config that referenced this pull request Dec 27, 2023
@aripollak aripollak deleted the cmp-scroll branch April 22, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants