Skip to content

pre-commit hooks has false positives #4

Description

@Raynos

When I use git add -p or even git add some files it will run my tests before the commit however the tests pass because of the unstaged changes I have locally.

If I were to stash before running npm test then the tests would have failed.

Is it the responsibility of pre-commit to ensure that the tests pass based on only the staged changes or is that the users responsibility ?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions