Skip to content

Bugfix/ip adapter#128

Merged
okotaku merged 3 commits into
okotaku:mainfrom
hirune924:bugfix/ip-adapter
Feb 5, 2024
Merged

Bugfix/ip adapter#128
okotaku merged 3 commits into
okotaku:mainfrom
hirune924:bugfix/ip-adapter

Conversation

@hirune924

@hirune924 hirune924 commented Feb 1, 2024

Copy link
Copy Markdown
Contributor

Motivation

  • Bug fix for ip-adapter not working with batch_size > 1.
  • Fix of the image url used in visualization.

Modification

  • Fix of the mistake in broadcast.
  • Fix of the image url used in visualization.

Results (Optional)

image

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

📚 Documentation preview 📚: https://DiffEngine--128.org.readthedocs.build/en/128/

@okotaku okotaku left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@okotaku

okotaku commented Feb 1, 2024

Copy link
Copy Markdown
Owner

@hirune924 The diffusers update caused the CI to fail. I am working on a fix.

@hirune924

Copy link
Copy Markdown
Contributor Author

Apologies, do you know the cause of this error? I've checked the error message, but I can't figure out why this change is triggering the error….

@okotaku

okotaku commented Feb 2, 2024

Copy link
Copy Markdown
Owner

@hirune924 Your PR is not the reason.

huggingface/diffusers#6573
This PR caused the error.

@hirune924

Copy link
Copy Markdown
Contributor Author

Thanks for your quick response! It makes things clear for me!

@okotaku okotaku merged commit 71631e9 into okotaku:main Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants