Skip to content

Add ZarrService#49

Closed
dgault wants to merge 1 commit into
ome:masterfrom
dgault:zarrService
Closed

Add ZarrService#49
dgault wants to merge 1 commit into
ome:masterfrom
dgault:zarrService

Conversation

@dgault

@dgault dgault commented May 5, 2020

Copy link
Copy Markdown
Member

Required for testing of ongoing Zarr reader and writer work

@sbesson

sbesson commented May 5, 2020

Copy link
Copy Markdown
Member

From Travis CI

+./minio version
‘version’ is not a minio sub-command. See ‘minio --help’.
The command "cd location-server && ./start-location.sh && cd .." failed and exited with 1 during .

This probably brings us back to the discussion in #47 (comment)

@sbesson

sbesson commented May 5, 2020

Copy link
Copy Markdown
Member

Once the Travis CI issue is fixed, should we release this immediately as a patch or minor release increment? This might be required to allow ome/bioformats#3554 to pass Travis and be included in the daily CI build /cc @joshmoore @jburel

@dgault

dgault commented May 5, 2020

Copy link
Copy Markdown
Member Author

I dont know about releasing it since this is very much a prototype for testing purposes only. I can hardcode the BF PR to just use the ZarrServiceImpl directly if that is easier for getting it into the daily merge build

@sbesson

sbesson commented May 5, 2020

Copy link
Copy Markdown
Member

Understood. 👍 for hard coding the service implementation in the Bio-Formats PR to get this easily deployed and tested for now.

@dgault dgault closed this May 5, 2020
@sbesson sbesson mentioned this pull request May 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dgault @sbesson