Skip to content

chore: seperate release plugins to a profile#467

Merged
Kavindu-Dodan merged 3 commits into
open-feature:mainfrom
Kavindu-Dodan:chore/deploy-profile
Jun 9, 2023
Merged

chore: seperate release plugins to a profile#467
Kavindu-Dodan merged 3 commits into
open-feature:mainfrom
Kavindu-Dodan:chore/deploy-profile

Conversation

@Kavindu-Dodan

@Kavindu-Dodan Kavindu-Dodan commented Jun 7, 2023

Copy link
Copy Markdown
Contributor

This PR

Attempts to improve local development experience by isolating artifact release time plugins into a dedicated profile. Profile deploy is activated by default, hence no change is needed in CI (GH Actions). However, the developer now can disable this profile with profile disable command <mvn command> -P -deploy so that they do not need to worry about deploy time executions (ex:- artifact signing)

How to use

For local development builds without release, signing and java docs use maven command - mvn clean install -P -deploy

@Kavindu-Dodan Kavindu-Dodan requested a review from a team as a code owner June 7, 2023 19:04
@Kavindu-Dodan Kavindu-Dodan changed the title chore : seperate deploy plugins to a profile chore: seperate deploy plugins to a profile Jun 7, 2023
@Kavindu-Dodan Kavindu-Dodan force-pushed the chore/deploy-profile branch from de6c8c9 to 36cff8d Compare June 7, 2023 19:35
@Kavindu-Dodan Kavindu-Dodan changed the title chore: seperate deploy plugins to a profile chore: seperate release plugins to a profile Jun 7, 2023
@codecov

codecov Bot commented Jun 7, 2023

Copy link
Copy Markdown

Codecov Report

Merging #467 (e7bced6) into main (3946211) will not change coverage.
The diff coverage is n/a.

❗ Current head e7bced6 differs from pull request most recent head a0a00bd. Consider uploading reports for the commit a0a00bd to get more accurate results

@@            Coverage Diff            @@
##               main     #467   +/-   ##
=========================================
  Coverage     94.44%   94.44%           
  Complexity      268      268           
=========================================
  Files            25       25           
  Lines           612      612           
  Branches         36       36           
=========================================
  Hits            578      578           
  Misses           17       17           
  Partials         17       17           
Flag Coverage Δ
unittests 94.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
@Kavindu-Dodan Kavindu-Dodan force-pushed the chore/deploy-profile branch from 36cff8d to 871d872 Compare June 8, 2023 16:48
@justinabrahms justinabrahms enabled auto-merge (squash) June 9, 2023 03:49
@justinabrahms justinabrahms disabled auto-merge June 9, 2023 03:51
@justinabrahms justinabrahms enabled auto-merge (squash) June 9, 2023 03:52
@justinabrahms justinabrahms disabled auto-merge June 9, 2023 03:53
@sonarqubecloud

sonarqubecloud Bot commented Jun 9, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Kavindu-Dodan Kavindu-Dodan merged commit 31f2148 into open-feature:main Jun 9, 2023
@toddbaert

Copy link
Copy Markdown
Member

This is a good addition. I'll add this to the CONTRIBUTING.md with one of my upcoming PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants