Skip to content

feat: add empty constructors to data classes#491

Merged
toddbaert merged 1 commit into
mainfrom
feat/add-empty-data-constructors
Jun 28, 2023
Merged

feat: add empty constructors to data classes#491
toddbaert merged 1 commit into
mainfrom
feat/add-empty-data-constructors

Conversation

@toddbaert

@toddbaert toddbaert commented Jun 26, 2023

Copy link
Copy Markdown
Member

See title.

I've also added tests to make sure we're aware of breaking changes with these constructors going forward.

Relates to: #483

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert toddbaert requested a review from a team as a code owner June 26, 2023 18:43
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov

codecov Bot commented Jun 26, 2023

Copy link
Copy Markdown

Codecov Report

Merging #491 (2cee8c3) into main (8b9e050) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #491   +/-   ##
=========================================
  Coverage     94.44%   94.44%           
  Complexity      268      268           
=========================================
  Files            25       25           
  Lines           612      612           
  Branches         36       36           
=========================================
  Hits            578      578           
  Misses           17       17           
  Partials         17       17           
Flag Coverage Δ
unittests 94.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ava/dev/openfeature/sdk/FlagEvaluationDetails.java 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@toddbaert toddbaert merged commit 693721e into main Jun 28, 2023
@toddbaert toddbaert deleted the feat/add-empty-data-constructors branch June 28, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants