Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/main/java/dev/openfeature/sdk/EventDetails.java
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package dev.openfeature.sdk;

import edu.umd.cs.findbugs.annotations.Nullable;
import lombok.Data;
import lombok.experimental.SuperBuilder;

Expand All @@ -19,8 +18,8 @@ static EventDetails fromProviderEventDetails(ProviderEventDetails providerEventD

static EventDetails fromProviderEventDetails(
ProviderEventDetails providerEventDetails,
@Nullable String providerName,
@Nullable String clientName) {
String providerName,
String clientName) {
return EventDetails.builder()
.clientName(clientName)
.providerName(providerName)
Expand Down
5 changes: 2 additions & 3 deletions src/main/java/dev/openfeature/sdk/EventSupport.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import lombok.extern.slf4j.Slf4j;

import javax.annotation.Nullable;
import java.util.ArrayList;
import java.util.List;
import java.util.Map;
Expand Down Expand Up @@ -41,7 +40,7 @@ class EventSupport {
* @param event the event type
* @param eventDetails the event details
*/
public void runClientHandlers(@Nullable String clientName, ProviderEvent event, EventDetails eventDetails) {
public void runClientHandlers(String clientName, ProviderEvent event, EventDetails eventDetails) {
clientName = Optional.ofNullable(clientName)
.orElse(defaultClientUuid);

Expand Down Expand Up @@ -74,7 +73,7 @@ public void runGlobalHandlers(ProviderEvent event, EventDetails eventDetails) {
* @param event the event type
* @param handler the handler function to run
*/
public void addClientHandler(@Nullable String clientName, ProviderEvent event, Consumer<EventDetails> handler) {
public void addClientHandler(String clientName, ProviderEvent event, Consumer<EventDetails> handler) {
final String name = Optional.ofNullable(clientName)
.orElse(defaultClientUuid);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

import java.util.Optional;

import javax.annotation.Nullable;

import lombok.AllArgsConstructor;
import lombok.Builder;
import lombok.Data;
Expand All @@ -23,12 +21,9 @@ public class FlagEvaluationDetails<T> implements BaseEvaluation<T> {

private String flagKey;
private T value;
@Nullable
private String variant;
@Nullable
private String reason;
private ErrorCode errorCode;
@Nullable
private String errorMessage;
@Builder.Default
private ImmutableMetadata flagMetadata = ImmutableMetadata.builder().build();
Expand Down
6 changes: 2 additions & 4 deletions src/main/java/dev/openfeature/sdk/OpenFeatureAPI.java
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
import java.util.Set;
import java.util.function.Consumer;

import javax.annotation.Nullable;

import dev.openfeature.sdk.exceptions.OpenFeatureError;
import dev.openfeature.sdk.internal.AutoCloseableLock;
import dev.openfeature.sdk.internal.AutoCloseableReentrantReadWriteLock;
Expand Down Expand Up @@ -67,14 +65,14 @@ public Client getClient() {
/**
* {@inheritDoc}
*/
public Client getClient(@Nullable String name) {
public Client getClient(String name) {
return getClient(name, null);
}

/**
* {@inheritDoc}
*/
public Client getClient(@Nullable String name, @Nullable String version) {
public Client getClient(String name, String version) {
return new OpenFeatureClient(this,
name,
version);
Expand Down
8 changes: 3 additions & 5 deletions src/main/java/dev/openfeature/sdk/ProviderEvaluation.java
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package dev.openfeature.sdk;

import javax.annotation.Nullable;

import lombok.AllArgsConstructor;
import lombok.Builder;
import lombok.Data;
Expand All @@ -18,10 +16,10 @@
@AllArgsConstructor
public class ProviderEvaluation<T> implements BaseEvaluation<T> {
T value;
@Nullable String variant;
@Nullable private String reason;
String variant;
private String reason;
ErrorCode errorCode;
@Nullable private String errorMessage;
private String errorMessage;
@Builder.Default
private ImmutableMetadata flagMetadata = ImmutableMetadata.builder().build();
}
8 changes: 3 additions & 5 deletions src/main/java/dev/openfeature/sdk/ProviderEventDetails.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

import java.util.List;

import javax.annotation.Nullable;

import lombok.Data;
import lombok.experimental.SuperBuilder;

Expand All @@ -12,7 +10,7 @@
*/
@Data @SuperBuilder(toBuilder = true)
public class ProviderEventDetails {
@Nullable private List<String> flagsChanged;
@Nullable private String message;
@Nullable private ImmutableMetadata eventMetadata;
private List<String> flagsChanged;
private String message;
private ImmutableMetadata eventMetadata;
}
4 changes: 1 addition & 3 deletions src/main/java/dev/openfeature/sdk/ProviderRepository.java
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@
import java.util.stream.Collectors;
import java.util.stream.Stream;

import javax.annotation.Nullable;

import dev.openfeature.sdk.exceptions.GeneralError;
import dev.openfeature.sdk.exceptions.OpenFeatureError;
import lombok.extern.slf4j.Slf4j;
Expand Down Expand Up @@ -100,7 +98,7 @@ public void setProvider(String clientName,
prepareAndInitializeProvider(clientName, provider, afterSet, afterInit, afterShutdown, afterError, waitForInit);
}

private void prepareAndInitializeProvider(@Nullable String clientName,
private void prepareAndInitializeProvider(String clientName,
FeatureProvider newProvider,
Consumer<FeatureProvider> afterSet,
Consumer<FeatureProvider> afterInit,
Expand Down