Skip to content

Drop NaN measurements to metric instruments#5859

Merged
jack-berg merged 2 commits into
open-telemetry:mainfrom
jack-berg:ignore-nan-measurements
Oct 2, 2023
Merged

Drop NaN measurements to metric instruments#5859
jack-berg merged 2 commits into
open-telemetry:mainfrom
jack-berg:ignore-nan-measurements

Conversation

@jack-berg

Copy link
Copy Markdown
Member

Resolves #5846.

@jack-berg jack-berg requested a review from a team September 27, 2023 20:12
@codecov

codecov Bot commented Sep 27, 2023

Copy link
Copy Markdown

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
...nternal/state/DefaultSynchronousMetricStorage.java 93.65% <100.00%> (+0.43%) ⬆️
...trics/internal/state/SdkObservableMeasurement.java 94.54% <100.00%> (+0.42%) ⬆️

... and 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@jkwatson jkwatson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Metrics SDK should ignore NaN measurement values

3 participants