Add sdk._logs directory to pyright, fix existing lint errors#4583
Add sdk._logs directory to pyright, fix existing lint errors#4583DylanRussell wants to merge 3 commits into
Conversation
…nto add_logs_to_typecheck
| severity_number: Optional[SeverityNumber] = None, | ||
| body: AnyValue = None, | ||
| attributes: Optional[_ExtendedAttributes] = None, | ||
| attributes: Optional[Attributes] = None, |
There was a problem hiding this comment.
Surprised, we have code passing _ExtendedAttributes here
There was a problem hiding this comment.
Well I think passing _ExtendedAttributes is in line with the spec: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/data-model.md#field-attributes .
But I also see #4587 which is doing the opposite of this -- basically making _ExtendedAttributes the default used everywhere (and renaming it to Attributes)
There was a problem hiding this comment.
#4587 is a prototype for a spec change, I hope to get this in well before that :)
|
This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment. |
|
This PR has been closed due to inactivity. Please reopen if you would like to continue working on it. |
github-project-automation
Bot
moved this from Reviewed PRs that need fixes
to Done
in Python PR digest
3 participants
Description
Add sdk._logs directory to pyright, fix existing lint errors.
Found what I think is a bug as well. See #4582
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit tests
Does This PR Require a Contrib Repo Change?
Checklist: