fix: raise ValueError for unsorted ExplicitBucketHistogramAggregation boundaries#5340
Open
RudraDudhat2509 wants to merge 4 commits into
Conversation
Author
tests pass on local |
xrmx
reviewed
Jun 22, 2026
| instrument_aggregation_temporality | ||
| ) | ||
| self._start_time_unix_nano = start_time_unix_nano | ||
| for i in range(1, len(boundaries)): |
Contributor
There was a problem hiding this comment.
Java also checks that first and last elements are not -inf and +inf, I guess it won't hurt
Author
|
good call added finite checks for NaN, +inf, and -inf, matching Java's full validation. tests added for all three cases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5338
What's wrong
ExplicitBucketHistogramAggregationaccepts unsorted boundary lists without any validation.bisect_left(used inaggregate()) requires sorted input with unsorted boundaries, measurements are silently placed in the wrong buckets with no error or warning.What this does
Adds a validation loop in
_ExplicitBucketHistogramAggregation.__init__that raisesValueErrorif boundaries are not strictly increasing. This matches the behavior of the Java SDK (IllegalArgumentException) and the Go SDK (non-monotonic boundarieserror).Tests
Added
test_unsorted_boundaries_raiseandtest_duplicate_boundaries_raisetoTestExplicitBucketHistogramAggregation.