fix(deploy_scale): dispatch to K8sDriver for a k8s-runtime fleet - #161
Merged
Merged
Conversation
deploy_scale/t_scale never got a k8s branch when studio#146 made the read path (list/get/runtime_context) k8s-aware — start/stop on a k8s-runtime fleet silently fell through to the ECS path with an empty cluster string, which AWS's ECS API treats as the literal "default" cluster, and with no fleet binding to match it, oab-mcp fell back to the local machine's default AWS credential chain. Reproduced live: stopping the "seaturtle" k8s test agent scaled a same-named ECS service in the wrong AWS account instead. t_scale now checks the named fleet's runtime first (mirroring t_list/t_get/t_runtime_context) and calls the new scp::scale_k8s_deployment (K8sDriver::scale) when it's k8s, before ever touching the ECS cluster arg. The console's start/stop button and the Tauri deploy_scale bridge now thread `fleet` through alongside `cluster`, same as the existing list/runtime_context calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploy_scale/t_scalenever got a k8s branch when studio#146 made the read path (deploy_list/deploy_get/runtime_context) k8s-aware — start/stop on a k8s-runtime fleet silently fell through to the ECS path with an empty cluster string, which AWS's ECS API treats as the literal"default"cluster, and with no fleet binding to match it, oab-mcp fell back to the local machine's default AWS credential chain.seaturtlek8s test agent (studio-fleet/orbstack) instead tried to scale a same-named ECS service in a different (wrong) AWS account —AccessDeniedExceptiononecs:UpdateService.t_scalenow checks the named fleet's runtime first (mirroringt_list/t_get/t_runtime_context) and calls the newscp::scale_k8s_deployment(K8sDriver::scale, already existed from feat(oabctl): K8sDriver skeleton — apply/scale/delete against a Deployment (slice 3b) #99) when it's k8s, before ever touching the ECSclusterarg. Console's start/stop button and the Taurideploy_scalebridge now threadfleetthrough alongsidecluster, same as the existingdeploy_list/runtime_contextcalls.Test plan
cargo check -p oab-mcp -p studio-cp— cleanconsole:npx tsc --noEmit— cleanconsole:npx vitest run— 117/117 passedseaturtlefrom the console and confirm it hitsK8sDriver::scale(orbstack), not ECS — not run in this session (no local k8s/AWS creds here)🤖 Generated with Claude Code