Skip to content

refactor: share comment scanners across detection and mapping - #203

Merged
steipete merged 1 commit into
mainfrom
refactor/phase-five-structure
Sep 12, 2026
Merged

refactor: share comment scanners across detection and mapping#203
steipete merged 1 commit into
mainfrom
refactor/phase-five-structure

Conversation

@steipete

Copy link
Copy Markdown
Contributor

What Problem This Solves

Project detection and language mappers maintained identical copies of the XML, line-comment, and Swift nested-comment scanners. Fixing either copy could leave detection and mapping inconsistent.

Why This Change Was Made

Move the existing implementations unchanged into one source-comment module and import them at each call site. No CLI behavior or runtime floor changes.

User Impact

Maintenance-only refactor; existing feature identities and discovery behavior are preserved.

Evidence

  • pnpm typecheck, pnpm lint, pnpm format:check, pnpm test, and pnpm build passed; 941 tests passed, 2 existing platform skips.
  • Isolated Codex autoreview: scoped-clean at P0–P2.
  • Live proof: invoked the rebuilt node dist/cli.js --root <synthetic-fixture> init --json --quiet and map --json --quiet. The fixture combines nested Swift comments, a commented-out executable declaration, and XML-commented .NET test metadata. The CLI mapped 4 features, including Swift executable Active; it did not map the commented executable or a spurious .NET test suite. Detection returned Swift/C#, SwiftPM/.NET, swift build, and no test command.

@steipete
steipete requested a review from a team as a code owner September 12, 2026 22:55
@clawsweeper

clawsweeper Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper

clawsweeper Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

ClawSweeper status: review started.

I am starting a fresh review of this pull request: refactor: share comment scanners across detection and mapping This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

@steipete
steipete merged commit c3b203c into main Sep 12, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant