refactor: simplify registry verification for Node 22 - #204
Merged
Conversation
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: refactor: simplify registry verification for Node 22 This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
The registry verifier retained a manual cancellation fallback for runtimes older than the declared Node 22 floor, plus multi-package processing after an earlier parser already restricted both fields to one package claim.
Why This Change Was Made
Use native
AbortSignal.anyand Node timer handles, remove the encoding wrapper, and verify the single matching claim directly. Keep the conservative publication policy and existing diagnostic strings unchanged. Trim comments that duplicated the implementation or documentation.User Impact
No behavior, CLI contract, or runtime-floor change.
Evidence
pnpm typecheck,pnpm lint,pnpm test src/registry-verifier.test.ts src/review-validation.test.ts, andpnpm buildpassed (61 tests).dist/registry-verifier.jsagainst a real local HTTP server. A matching published manifest dropped the finding; caller abort and a 25 ms deadline both returnedunknownand kept findings. No mocked fetch implementation was used.