Skip to content

refactor: simplify registry verification for Node 22 - #204

Merged
steipete merged 1 commit into
mainfrom
refactor/phase-five-runtime
Sep 12, 2026
Merged

refactor: simplify registry verification for Node 22#204
steipete merged 1 commit into
mainfrom
refactor/phase-five-runtime

Conversation

@steipete

Copy link
Copy Markdown
Contributor

What Problem This Solves

The registry verifier retained a manual cancellation fallback for runtimes older than the declared Node 22 floor, plus multi-package processing after an earlier parser already restricted both fields to one package claim.

Why This Change Was Made

Use native AbortSignal.any and Node timer handles, remove the encoding wrapper, and verify the single matching claim directly. Keep the conservative publication policy and existing diagnostic strings unchanged. Trim comments that duplicated the implementation or documentation.

User Impact

No behavior, CLI contract, or runtime-floor change.

Evidence

  • pnpm typecheck, pnpm lint, pnpm test src/registry-verifier.test.ts src/review-validation.test.ts, and pnpm build passed (61 tests).
  • Isolated Codex autoreview is scoped-clean at P0–P2. An initial diff-only pass lacked the unchanged claim-parser definition; a full-source/context pass verified its single-package invariant.
  • Live compiled-runtime proof: ran dist/registry-verifier.js against a real local HTTP server. A matching published manifest dropped the finding; caller abort and a 25 ms deadline both returned unknown and kept findings. No mocked fetch implementation was used.

@clawsweeper

clawsweeper Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper

clawsweeper Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

ClawSweeper status: review started.

I am starting a fresh review of this pull request: refactor: simplify registry verification for Node 22 This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

@steipete
steipete merged commit cee63ae into main Sep 12, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant