refactor: organize mapper tests by language and enforce typed fixtures - #205
Merged
Conversation
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
A single 17,410-line mapper test file mixed 434 cases from unrelated languages and frameworks, making focused runs and maintenance difficult. Retry tests bypassed the real provider contract with
any, and fixture directories remained after tests.User Impact
No CLI behavior changes. Contributors can run the relevant language's tests directly; test fixtures clean up after each case, and TypeScript catches unused locals and parameters.
Why This Change Was Made
Move the existing mapper cases beside their language modules, retaining cross-mapper coverage in
mapper.test.ts. Preserve every mapper test body and existing platform gate. Use complete typed provider fixtures and remove the two unused parameters found by the compiler before enabling its unused-code checks.Evidence
pnpm typecheck,pnpm lint,pnpm format:check,pnpm test, andpnpm buildpassed. The same 941 tests pass with the same 2 platform skips, now across 48 files.pnpm pack:smokebuilt the tarball, installed it with production dependencies offline, and ran the installed CLI:packaged CLI smoke mapped 13 features (3 CUDA).