refactor: share mapper metadata parsing and file references - #206
Merged
Conversation
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: refactor: share mapper metadata parsing and file references This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Initialization and mapper modules copied the same Python metadata scanners, Node workspace pattern matching, and file-reference deduplication. Their shared behavior could drift when a fix was applied to only one copy.
User Impact
No behavior or runtime-floor changes. Feature identity, ordering, and path filtering remain unchanged.
Why This Change Was Made
Share exact common implementations while retaining language-specific traversal and interpretation. Keep the first file reference for each path, as before. Remove unreachable workspace suffix branches that were already handled by the earlier wildcard branch.
Evidence
pnpm typecheck,pnpm lint,pnpm format:check,pnpm test, andpnpm buildpassed: 941 passed, 2 existing platform skips.pnpm pack:smokebuilt/installed the package offline and ran its CLI against a mixed Python/Next/CUDA fixture:packaged CLI smoke mapped 13 features (3 CUDA).