Skip to content

refactor: remove dead task helper and normalize internal test hooks - #208

Merged
steipete merged 1 commit into
mainfrom
refactor/phase-five-dead-code
Sep 12, 2026
Merged

refactor: remove dead task helper and normalize internal test hooks#208
steipete merged 1 commit into
mainfrom
refactor/phase-five-dead-code

Conversation

@steipete

Copy link
Copy Markdown
Contributor

What Problem This Solves

The final source sweep found an unused task-graph command collector and internal test hooks whose names required lint suppression.

User Impact

No CLI behavior or public configuration changes.

Why This Change Was Made

Delete the unreferenced collector and give the internal hooks the same descriptive naming used by the provider modules. Remove the now-unneeded suppression comments rather than changing lint rules.

Evidence

  • pnpm typecheck, pnpm lint, pnpm format:check, focused mapper/provider/retry tests (189 passed), and pnpm build passed.
  • Isolated Codex autoreview: scoped-clean at P0–P2 against the final formatted files.
  • Live rebuilt CLI walkthrough with the deterministic mock provider: mapped 4 features, reviewed 3, reported 2 findings, inspected and previewed a fix, revalidated, and cleaned stale locks.
  • Repository-wide symbol search confirmed the removed helper had no callers.

@steipete
steipete requested a review from a team as a code owner September 12, 2026 23:08
@clawsweeper

clawsweeper Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper

clawsweeper Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

ClawSweeper status: review started.

I am starting a fresh review of this pull request: refactor: remove dead task helper and normalize internal test hooks This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

@steipete
steipete merged commit 88c609d into main Sep 12, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant